Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Comfy.ComfyUI-Desktop version 0.3.18 #194595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: Comfy.ComfyUI-Desktop version 0.3.18 #194595

wants to merge 1 commit into from
+47 −0

Conversation

jo-chemla
Copy link
Contributor

@jo-chemla jo-chemla commented Nov 27, 2024 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with komac v2.6.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@jo-chemla jo-chemla mentioned this pull request Nov 27, 2024
Open
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2024
@jo-chemla
Copy link
Contributor Author

Hi there, automatic install worked on my machine via winget install -m path-to-manifest

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 27, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 899.)

@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Dec 8, 2024
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Dec 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 9, 2024
@jo-chemla jo-chemla mentioned this pull request Dec 9, 2024
Open
@jo-chemla
Copy link
Contributor Author

Request to publish comfyUI desktop via future-proof urls on github releases done here Comfy-Org/desktop#455
Otherwise, should I just re-submit the package with the vanity url so the sha256 do match during validation - so then users willing to install ComfyDesktop it can simply do it and accept package hash mismatch?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 9, 2024
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2024-12-10 13:53:58.505 [CLI ] Package hash verification failed. SHA256 in manifest [f4b5b64a902afdbddf39ee2f7e5748afadd8d5017a9ca5deaa351ed42d78faff] does not match download [992e741fb5956aa96061f54345f675292c4672a2aed19cbaa5c38bbde0941452] with file size [111905608] and content type []

(Automated response - build 903.)

@sync-by-unito sync-by-unito bot mentioned this pull request Dec 17, 2024
Closed
@Trenly Trenly mentioned this pull request Dec 19, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jo-chemla jo-chemla

@stephengillie stephengillie

Labels
Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Attention This work item needs to be reviewed by a member of the core team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jo-chemla @wingetbot @stephengillie @ItzLevvie